-
Notifications
You must be signed in to change notification settings - Fork 536
Fix $bulk-delete bugs with custom search parameter #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BulkDeleteTests.cs
Fixed
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BulkDeleteTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterStatusManager.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Registry/SearchParameterStatusManager.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Search/Parameters/SearchParameterOperations.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/Microsoft.Health.Fhir.Core/Features/Definition/SearchParameterDefinitionManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Persistence/IDeletionService.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe the response from the deletion service can be a list of resource wrappers due to memory limitations.
We have reverted it back to returning the stats dictionary. We have also added an optional parameter to DeleteMultipleAsync to store deleted search parameters. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
The PR will address an issue of the search parameter status going out of sync after $bulk-delete removes search parameter resources.
Related issues
Addresses [issue #121676].
Bug 121676: Hard delete custom search parameter not cleaning up all the data
Testing
Tested manually and also through adding E2E test.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)